Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Implement dotfiles #220

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Implement dotfiles #220

merged 5 commits into from
Jan 24, 2020

Conversation

kyujin-cho
Copy link
Member

This PR resolves issue lablup/backend.ai#98.

What has changed?

  • Added dotfiles column to keypairs table
  • New /dotfile endpoint for basic CRUD operation of dotfiles
    • GET /dotfile: Lists all available dotfiles per user
    • GET /dotfile?path=<SOMEPATH>: Returns information of dotfile with given path
    • POST /dotfile: Creates new dotfile
    • PATCH /dotfile: Updates dotfile with given patgh
    • `DELETE /dotfile?path=: Deletes dotfile from user with given path
  • Manager now passes dotfiles list inside internal_data column to agent when creating kernel

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #220 into master will increase coverage by 0.1%.
The diff coverage is 68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #220     +/-   ##
=========================================
+ Coverage   45.87%   45.97%   +0.1%     
=========================================
  Files          36       36             
  Lines        5783     5805     +22     
=========================================
+ Hits         2653     2669     +16     
- Misses       3130     3136      +6
Impacted Files Coverage Δ
src/ai/backend/gateway/server.py 52.56% <ø> (ø) ⬆️
src/ai/backend/manager/registry.py 13.48% <0%> (-0.05%) ⬇️
src/ai/backend/gateway/exceptions.py 87.07% <100%> (+0.68%) ⬆️
src/ai/backend/manager/models/keypair.py 45.36% <66.66%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630c768...045c9aa. Read the comment docs.

Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to put the dotfiles APIs under "user-config" API set.
So, please rename gateway/dotfile.py to gateway/userconfig.py and use additional prefix levels /user-config/dotfiles instead of /dotfile.

src/ai/backend/manager/models/keypair.py Outdated Show resolved Hide resolved
src/ai/backend/gateway/dotfile.py Outdated Show resolved Hide resolved
src/ai/backend/gateway/dotfile.py Outdated Show resolved Hide resolved
src/ai/backend/gateway/dotfile.py Outdated Show resolved Hide resolved
src/ai/backend/gateway/dotfile.py Outdated Show resolved Hide resolved
src/ai/backend/gateway/dotfile.py Outdated Show resolved Hide resolved
@achimnol achimnol merged commit 13fb345 into master Jan 24, 2020
@achimnol achimnol deleted the feature/dotfiles branch January 24, 2020 04:21
adrysn added a commit that referenced this pull request Jan 31, 2020
* Backport from 19.12 branch.
* Remove Python 3.6-incompatible typing codes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants