This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=========================================
+ Coverage 45.87% 45.97% +0.1%
=========================================
Files 36 36
Lines 5783 5805 +22
=========================================
+ Hits 2653 2669 +16
- Misses 3130 3136 +6
Continue to review full report at Codecov.
|
achimnol
suggested changes
Jan 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to put the dotfiles APIs under "user-config" API set.
So, please rename gateway/dotfile.py
to gateway/userconfig.py
and use additional prefix levels /user-config/dotfiles
instead of /dotfile
.
src/ai/backend/manager/models/alembic/versions/1e8531583e20_add_dotfile_column_to_keypairs.py
Outdated
Show resolved
Hide resolved
adrysn
added a commit
that referenced
this pull request
Jan 31, 2020
* Backport from 19.12 branch. * Remove Python 3.6-incompatible typing codes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue lablup/backend.ai#98.
What has changed?
dotfiles
column tokeypairs
table/dotfile
endpoint for basic CRUD operation of dotfilesGET /dotfile
: Lists all available dotfiles per userGET /dotfile?path=<SOMEPATH>
: Returns information of dotfile with given pathPOST /dotfile
: Creates new dotfilePATCH /dotfile
: Updates dotfile with given patghdotfiles
list insideinternal_data
column to agent when creating kernel