Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Conversation

vesselofgod
Copy link
Contributor

@vesselofgod vesselofgod commented Feb 19, 2022

This is a follow-up to lablup/backend.ai#343
Related with: lablup/backend.ai-webui#1190

prevent allowed session types in empty and fix allowed session types check process handing

  • Prevent allowed_session_types in empty status using trafaret.
    Change it not to be empty to solve problem of If the scaling group's allowed_session_types is empty, predicate check fail failure.
    비어있는 경우
    비어있는 경우가 없도록 수정

  • Fix allowed_session_types check process handing
    Prevent stopping without checking all sgroups during the allowed_session_types check process

@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #542 (b85dcf5) into main (b947549) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
+ Coverage   48.86%   49.13%   +0.26%     
==========================================
  Files          54       54              
  Lines        9024     9031       +7     
==========================================
+ Hits         4410     4437      +27     
+ Misses       4614     4594      -20     
Impacted Files Coverage Δ
src/ai/backend/manager/models/scaling_group.py 66.25% <ø> (ø)
src/ai/backend/manager/scheduler/predicates.py 52.52% <100.00%> (+25.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b947549...b85dcf5. Read the comment docs.

@achimnol achimnol changed the title Fix/prevent allowed session types in empty and fix allowed session types check process handing fix: Don't allow empty values in allowed session types and scan all allowed scaling groups Mar 4, 2022
@achimnol achimnol merged commit d04d3c1 into main Mar 4, 2022
@achimnol achimnol deleted the fix/Prevent-allowed_session_types-in-empty-and-fix-allowed_session_types-check-process-handing branch March 4, 2022 08:36
@achimnol achimnol added this to the 22.03 milestone Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants