Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make gpu required image available to download #1337

Merged
merged 2 commits into from
Jul 10, 2022
Merged

fix: make gpu required image available to download #1337

merged 2 commits into from
Jul 10, 2022

Conversation

agatha197
Copy link
Contributor

  • fix: value disappears when moving the slider to modify the image resource limit
  • fix: lint errors

this resolves #1131

@agatha197
fix: make gpu-required image available to download
8fb1936 
- fix: value disappears when moving slider to modify image resource limit
@agatha197
fix: lint errors
c035db0
@agatha197 agatha197 added type:fix Fix features that are not working effort:normal Need to understand a few modules / some extent of contextual or historical information. area:ux UI / UX issue. urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING labels Jun 29, 2022
@agatha197 agatha197 added this to the 22.03 milestone Jun 29, 2022
@agatha197 agatha197 self-assigned this Jun 29, 2022
adrysn
adrysn approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@adrysn adrysn merged commit 3985d25 into main Jul 10, 2022
@adrysn adrysn deleted the bugfix/make-gpu-required-image-available-to-download branch July 10, 2022 16:09
@Yaminyam Yaminyam added the size:L 100~500 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrysn adrysn adrysn approved these changes

@inureyes inureyes Awaiting requested review from inureyes

@lizable lizable Awaiting requested review from lizable

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. effort:normal Need to understand a few modules / some extent of contextual or historical information. size:L 100~500 LoC type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING
Projects
None yet
Milestone
22.03
Development

Successfully merging this pull request may close these issues.

Let's make GPU-required image available to download if none of the agent doesn't have GPU resources.
3 participants
@agatha197 @adrysn @Yaminyam