Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable container commit when session is batch type #1438

Merged

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Aug 25, 2022

Description

This PR fixes two things, disable container commit icon when the session is BATCH type and adjust the width of Controls column depending on whether the version and configuration support container commit.

Screenshots

Before

before-container-commit-icon-arrangement-fixed

After

after-container-commit-icon-arrangement-fixed

@lizable lizable added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. labels Aug 25, 2022
@lizable lizable added this to the 22.09 milestone Aug 25, 2022
@lizable lizable self-assigned this Aug 25, 2022
@github-actions github-actions bot removed the area:ux UI / UX issue. label Aug 25, 2022
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit 63a1b1d into main Aug 25, 2022
@inureyes inureyes deleted the fix/disable-container-commit-when-session-is-batch-type branch August 25, 2022 04:26
@Yaminyam Yaminyam added the size:S 10~30 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). size:S 10~30 LoC type:fix Fix features that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants