Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add modal to enter SSH keypair manually #1578

Merged
merged 4 commits into from
Feb 10, 2023
Merged

feat: Add modal to enter SSH keypair manually #1578

merged 4 commits into from
Feb 10, 2023

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 10, 2023 •
edited
Loading

@lizable lizable self-requested a review February 10, 2023 05:16
@lizable lizable added urgency:3 Must be finished within a certain time frame. type:enhance Add new features labels Feb 10, 2023
lizable
lizable approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yomybaby It works fine, but I slightly did a touch-up for a better user experience.
I think it's okay to merge.

src/components/backend-ai-usersettings-general-list.ts Show resolved Hide resolved
src/components/backend-ai-usersettings-general-list.ts Show resolved Hide resolved
@yomybaby yomybaby merged commit f08becd into main Feb 10, 2023
@yomybaby yomybaby deleted the feature/ssh-keypair-manually branch February 10, 2023 07:31
@adrysn adrysn mentioned this pull request Feb 11, 2023
Merged
@inureyes inureyes added area:ux UI / UX issue. area:i18n Localization and removed field:UI / UX labels Mar 27, 2023
@Yaminyam Yaminyam added the size:L 100~500 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizable lizable lizable approved these changes

Assignees

@yomybaby yomybaby

Labels
area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC type:enhance Add new features urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yomybaby @lizable @inureyes @Yaminyam