fix: http status code #1833
Merged
fix: http status code #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using 404, it can be assumed that the API endpoint itself does not exist. Since this error is a configuration error, 500 status code is appropriate.
pderer
added
type:fix
added 2 commits
August 9, 2023 06:26
- fix/http-status-code-when-unable-to-terminate -compute-session-when-wsproxy-address-is-not-properly
- for backward compatibility with 22.09, 404 status code should be included.
inureyes
deleted the
fix/http-status-code-when-unable-to-terminate-compute-session-when-wsproxy-address-is-not-properly
branch
mnxmnz
pushed a commit
to lablup/backend.ai-webui-ossca-2023
that referenced
this pull request
Aug 10, 2023
* fix: http status code - Using 404, it can be assumed that the API endpoint itself does not exist. Since this error is a configuration error, 500 status code is appropriate. * fix: http status code backward compatibility - for backward compatibility with 22.09, 404 status code should be included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to these PRs
Using 404 http status code, it can be assumed that the API endpoint does not exist.
Since this error is a configuration error, 500 status code is appropriate.
For backward compatibility with 22.09, 404 status code should be included.