Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add allowAppDownloadPanel that can hide app download panel #1996

Merged
merged 2 commits into from
Nov 5, 2023
Merged

feat: add allowAppDownloadPanel that can hide app download panel #1996

merged 2 commits into from
Nov 5, 2023

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Oct 27, 2023 •
edited
Loading

resolves #1979
If allowAppDownloadPanel is true, display the webui app download panel on the summary page. Or, hide it.

How to test:

  1. set allowAppDownloadPanel to the config.toml
  2. check the app download panel is hidden/shown according to the option.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version : 22.09
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:enhance Add new features effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. platform:web Web-specific issue urgency:3 Must be finished within a certain time frame. impact:visible This change is visible to users. field:UI / UX labels Oct 27, 2023
@agatha197 agatha197 added this to the 23.09 milestone Oct 27, 2023
@agatha197 agatha197 self-assigned this Oct 27, 2023
@github-actions github-actions bot added impact:invisible This change is invisible to users (internal changes). size:S 10~30 LoC and removed field:UI / UX labels Oct 27, 2023
@aws-amplify-ap-northeast-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1996.d3g9cs6u59b8lw.amplifyapp.com

@agatha197 agatha197 changed the title feat: add allowAppDownloadUrl that can hide app download panel feat: add allowAppDownloadPanel that can hide app download panel Oct 27, 2023
This was referenced Oct 27, 2023
Merged
Closed
inureyes
inureyes approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit fe1beb9 into main Nov 5, 2023
6 checks passed
@inureyes inureyes deleted the feature/hide-app-download-panel branch November 5, 2023 05:02
@lizable lizable mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inureyes inureyes inureyes approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:invisible This change is invisible to users (internal changes). impact:visible This change is visible to users. platform:web Web-specific issue size:S 10~30 LoC type:enhance Add new features urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Add option for hiding WebUI app download panel.
2 participants
@agatha197 @inureyes