Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update VFolder operation statuses #2031

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

rapsealk
Copy link
Member

This PR is a follow-up of lablup/backend.ai#835.

This PR adds a type to represent VFolder's operations statuses and updated some code as the upstream PR has renamed VFolder status deleting to delete-ongoing.

Minimum required manager version: 24.03

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@rapsealk rapsealk added this to the 24.03 milestone Nov 20, 2023
@rapsealk rapsealk self-assigned this Nov 20, 2023
@rapsealk rapsealk changed the title feauret: rename vfolder status deleting to delete-ongoing feature: rename vfolder status deleting to delete-ongoing Nov 20, 2023
@github-actions github-actions bot added the size:S 10~30 LoC label Nov 20, 2023
@rapsealk rapsealk added the comp:manager Related to Manager component label Nov 20, 2023
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2031.d3g9cs6u59b8lw.amplifyapp.com

@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Nov 23, 2023
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapsealk rapsealk changed the title feature: rename vfolder status deleting to delete-ongoing feat: rename vfolder status deleting to delete-ongoing Jan 27, 2024
return [
'performing',
'cloning',
'mounted',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question is not about the changes in this PR. Is it correct that the mounted status is an uncontrollable status and disables the share feature?
@rapsealk @agatha197

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In accordance with the Backend.AI manager implementation, the status VFolderOperationStatus.MOUNTED is interpreted as both READABLE and UPDATABLE, signifying that a mounted status is still eligible for sharing. The relevant code snippet can be found at:
https://github.com/lablup/backend.ai/blob/32a0553839b489b83daa226a90ad482cda87c788/src/ai/backend/manager/api/vfolder.py#L147-L160

@agatha197
Copy link
Contributor

@rapsealk please resolve the conflicts :)

@rapsealk
Copy link
Member Author

rapsealk commented Feb 5, 2024

@agatha197 Resolved conflicts by deleting session-launcher-neo.ts. Please check!

@agatha197 agatha197 changed the title feat: rename vfolder status deleting to delete-ongoing feat: update VFolder operation statuses Feb 5, 2024
@agatha197 agatha197 merged commit 1f3216c into main Feb 5, 2024
6 checks passed
@agatha197 agatha197 deleted the feature/update-vfolder-status-rename branch February 5, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants