-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update VFolder operation statuses #2031
Conversation
deleting
to delete-ongoing
deleting
to delete-ongoing
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
deleting
to delete-ongoing
deleting
to delete-ongoing
return [ | ||
'performing', | ||
'cloning', | ||
'mounted', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This question is not about the changes in this PR. Is it correct that the mounted
status is an uncontrollable status and disables the share feature?
@rapsealk @agatha197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In accordance with the Backend.AI manager implementation, the status VFolderOperationStatus.MOUNTED
is interpreted as both READABLE
and UPDATABLE
, signifying that a mounted status is still eligible for sharing. The relevant code snippet can be found at:
https://github.com/lablup/backend.ai/blob/32a0553839b489b83daa226a90ad482cda87c788/src/ai/backend/manager/api/vfolder.py#L147-L160
@rapsealk please resolve the conflicts :) |
@agatha197 Resolved conflicts by deleting |
deleting
to delete-ongoing
This PR is a follow-up of lablup/backend.ai#835.
This PR adds a type to represent VFolder's operations statuses and updated some code as the upstream PR has renamed VFolder status
deleting
todelete-ongoing
.Minimum required manager version: 24.03
Checklist: (if applicable)