Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:The Credential View displays a list that does not match the sub-tab #2055

Merged
merged 1 commit into from Dec 12, 2023
Merged

fix:The Credential View displays a list that does not match the sub-tab #2055

merged 1 commit into from Dec 12, 2023

Conversation

gee05053
Copy link
Member

@gee05053 gee05053 commented Nov 27, 2023 •
edited

This PR resolves issue #2050
Admin can see right active list-view whether admin move to other main menu.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@gee05053 gee05053 added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). size:S 10~30 LoC labels Nov 27, 2023
@gee05053 gee05053 self-assigned this Nov 27, 2023
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2055.d3g9cs6u59b8lw.amplifyapp.com

@inureyes inureyes changed the title Fix:The Credential View displays a list that does not match the sub-tab fix:The Credential View displays a list that does not match the sub-tab Nov 28, 2023
@gee05053 gee05053 linked an issue Dec 4, 2023 that may be closed by this pull request
Fix:The Credential View displays a list that does not match the sub-tab #2050
Closed
@lizable lizable self-requested a review December 12, 2023 03:13
lizable
lizable approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lizable lizable merged commit 1a45311 into main Dec 12, 2023
10 checks passed
@lizable lizable deleted the fix/credential-view-show-wrong-list branch December 12, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizable lizable lizable approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@gee05053 gee05053

Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). size:S 10~30 LoC type:fix Fix features that are not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix:The Credential View displays a list that does not match the sub-tab
2 participants
@gee05053 @lizable