Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show antd error message when failed to terminate in-service model #2157

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Jan 19, 2024

This PR resolves #2154

Introduces

  • set mutation Error type to access the error message
  • show error message by using antd message

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

cla-assistant bot commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added effort:easy Need to understand only a specific region of codes (good first issue, easy). field:UI / UX size:S 10~30 LoC and removed field:UI / UX labels Jan 19, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2157.d3g9cs6u59b8lw.amplifyapp.com

Copy link

github-actions bot commented Jan 19, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
3.44% (-0% 🔻)
100/2907
🔴 Branches
3.77% (-0% 🔻)
67/1779
🔴 Functions 1.69% 17/1004
🔴 Lines
3.5% (-0% 🔻)
100/2854

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from cf54580

}),
);
} else {
message.error(t('modelService.FailedToTerminateService'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to submit modelService.FailedToTerminateService values?

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit d2ddb6f into main Jan 19, 2024
7 of 8 checks passed
@yomybaby yomybaby deleted the fix/terminate-service-modal branch January 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). field:localization field:UI / UX size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's Make an error message visible in the UI when deleting a service model
2 participants