Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate the formatting and linting configuration #2162

Merged
merged 12 commits into from
Jan 29, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Jan 22, 2024

This PR resolves #2137 issue

Changes

  • Eslint and Prettier version integration between React and Lit
  • Separate formatting and linting scripts
  • Ignore eslint rules that conflict with prettier formatting rules
    • "object-curly-spacing": "off": Disables the rule that enforces spacing inside curly braces {} in object literals.
    • "operator-linebreak": "off": Disables the rule that enforces consistent linebreaks for operators.
    • "indent": "off": Disables the rule that enforces a specific indentation style.
    • "no-unused-vars": "off": Disables warnings for unused variables.
    • "no-undef": "off": Disables warnings for using undeclared variables.
    • "no-constant-condition": "off": Disables warnings for constant expressions in conditions.
    • "no-inner-declarations": "off": Disables the rule that forbids function declarations in nested blocks.
    • "no-irregular-whitespace": "off": Disables warnings for irregular whitespace outside of strings and comments.
    • "max-len": "off": Disables the rule that enforces a maximum line length.
    • "@typescript-eslint/no-explicit-any": "off": Disables warnings for using the any type in TypeScript.
    • "require-jsdoc": "off": Disables the rule that requires JSDoc comments for every function.
    • "camelcase": "off": Disables the rule that enforces camelCase naming convention for variable and function names.
    • "spaced-comment": "off": Disables the rule that enforces spacing after the comment start symbol.
    • "quotes": "off": Disables the rule that enforces the use of a specific quote type (e.g., single or double quotes) for strings.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:L 100~500 LoC label Jan 22, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2162.d3g9cs6u59b8lw.amplifyapp.com

@yomybaby yomybaby self-requested a review January 22, 2024 06:08
Copy link

github-actions bot commented Jan 29, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3.15% 101/3205
🔴 Branches 3.34% 67/2006
🔴 Functions 1.56% 17/1092
🔴 Lines 3.21% 101/3146

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from ffe75f6

yomybaby

This comment was marked as resolved.

@yomybaby yomybaby changed the title feat: update linter command feat: separate the formatting and linting configuration Jan 29, 2024
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yomybaby yomybaby merged commit f137435 into main Jan 29, 2024
8 checks passed
@yomybaby yomybaby deleted the feat/update-linter-command branch January 29, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update linter command in node package
2 participants