Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter props of VFolderTableFormItem #2173

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Jan 24, 2024

resolve #2171

This PR introduces filter props of VFolderTableFormItem and sets filter to neo session launcher vFolder form item to show only ready folders.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added impact:visible This change is visible to users. neo session launcher platform:general type:fix Fix features that are not working urgency:1 If no other duties are available, volunteer to help. size:S 10~30 LoC labels Jan 24, 2024
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
3.44% (-0% 🔻)
100/2908
🔴 Branches 3.77% 67/1779
🔴 Functions
1.69% (-0% 🔻)
17/1005
🔴 Lines
3.5% (-0% 🔻)
100/2855

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from d904624

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2173.d3g9cs6u59b8lw.amplifyapp.com

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agatha197 agatha197 merged commit 7dc3d15 into main Jan 26, 2024
9 checks passed
@agatha197 agatha197 deleted the feature/filter-prop-of-VFolderTableFormItem branch January 26, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:visible This change is visible to users. neo session launcher platform:general size:S 10~30 LoC type:fix Fix features that are not working urgency:1 If no other duties are available, volunteer to help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete-compelete folders are displayed to the neo-session mount folder list.
2 participants