feat: add draggable prop of BAIModal to drag modal #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 3.14% (-0.01% 🔻) |
101/3219 |
| 🔴 | Branches | 3.32% (-0.02% 🔻) |
67/2018 |
| 🔴 | Functions | 1.55% (-0.01% 🔻) |
17/1097 |
| 🔴 | Lines | 3.2% (-0.01% 🔻) |
101/3160 |
Test suite run success
20 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from fa07101
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
yomybaby
requested changes
Jan 29, 2024
There was a problem hiding this comment.
I already gave feedback on the Teams channel. But I want to summarize that:
- Make only a specific area next to the title draggable, and do not limit the movable screen area, allowing dragging anywhere on the screen.
- no scroll appears even if a modal goes outside the screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2149
If you set draggable in BAIModal, you can drag modal.
You can drag only when your mouse cursor is over header.
I also modify close button of width and height in header
you need to
npm installto install react-draggable2024-01-30.2.39.56.mov
Checklist: (if applicable)