Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image info(metadata) can be undefined #2197

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 1, 2024

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:XS ~10 LoC label Feb 1, 2024
@yomybaby yomybaby changed the title add an undefined type to imageInfo and a conditional chain fix: image info can be undefined Feb 1, 2024
@yomybaby yomybaby changed the title fix: image info can be undefined fix: image info(metadata) can be undefined Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3.14% 101/3219
🔴 Branches 3.32% 67/2018
🔴 Functions 1.55% 17/1097
🔴 Lines 3.2% 101/3160

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from a21b5f2

@yomybaby yomybaby merged commit f46d6fd into main Feb 1, 2024
8 of 9 checks passed
@yomybaby yomybaby deleted the fix/imageInfo-can-be-undefined branch February 1, 2024 03:17
@yomybaby
Copy link
Member Author

yomybaby commented Feb 1, 2024

I merged this without review because it's a hotfix and doesn't change the logic at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant