Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent modifying DESTROYING status services #2200

Merged
merged 1 commit into from
Feb 6, 2024
Merged

feat: prevent modifying DESTROYING status services #2200

merged 1 commit into from
Feb 6, 2024

Conversation

ironAiken2
Copy link
Contributor

This PR resolves #2195

feature:

  • Gets the status data and uses it for the button disable property.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). field:UI / UX impact:visible This change is visible to users. platform:general type:fix Fix features that are not working urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. size:XS ~10 LoC labels Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024 •
edited

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
3.14% (+0% 🔼)
 101/3219
🔴 Branches
3.32% (-0% 🔻)
 67/2020
🔴 Functions
1.55% (+0% 🔼)
 17/1097
🔴 Lines
3.2% (+0% 🔼)
 101/3160

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from afaccb6

@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2200.d3g9cs6u59b8lw.amplifyapp.com

@yomybaby yomybaby requested a review from lizable February 1, 2024 22:39
@yomybaby
Copy link
Member

yomybaby commented Feb 5, 2024

@ironAiken2 Please don't forget to add the Frontend daily board project when you do something.

@ironAiken2 ironAiken2 force-pushed the fix/destroying-status-services branch from e05a123 to afaccb6 Compare February 6, 2024 03:48
agatha197
agatha197 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 merged commit 47b288e into main Feb 6, 2024
12 of 13 checks passed
@agatha197 agatha197 deleted the fix/destroying-status-services branch February 6, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@lizable lizable Awaiting requested review from lizable

Assignees

@ironAiken2 ironAiken2

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). field:UI / UX impact:visible This change is visible to users. platform:general size:XS ~10 LoC type:fix Fix features that are not working urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's prevent modifying DESTROYING status services.
3 participants
@ironAiken2 @yomybaby @agatha197