Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resource-monitor is shown at out of layout #2207

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

gee05053
Copy link
Contributor

@gee05053 gee05053 commented Feb 13, 2024

This PR resolves resource-monitor's layout issue that is occurred after merging #2166

How to reproduce this bug:

  • make long resource group name
  • Go to the session page(/job)
  • Reduce the browser window size as possible.

Before
스크린샷 2024-02-13 오후 5 23 09

After
스크린샷 2024-02-13 오후 5 43 39

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@gee05053 gee05053 self-assigned this Feb 13, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Feb 13, 2024
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3.12% 101/3234
🔴 Branches 3.3% 67/2031
🔴 Functions 1.55% 17/1100
🔴 Lines 3.18% 101/3174

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from d1c7a94

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2207.d3g9cs6u59b8lw.amplifyapp.com

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.
I'll merge this now. However, we need to refactor this layout in the near future.

@yomybaby yomybaby merged commit 6a5b22f into main Feb 19, 2024
9 checks passed
@yomybaby yomybaby deleted the fix/resource-monitor-layout branch February 19, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants