Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when user menu is clicked, credential tab is shown instead of user. #2208

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: when user menu is clicked, credential tab is shown instead of user. #2208

merged 1 commit into from
Feb 14, 2024

Conversation

gee05053
Copy link
Contributor

@gee05053 gee05053 commented Feb 13, 2024 •
edited

This PR resolve to fix credential in sidebar is shown keypair-list after merging #2194

How to reproduce this bug:

  • Login and go to the credential page to click credential in sidebar
  • You can show keypair-list

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@gee05053 gee05053 self-assigned this Feb 13, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Feb 13, 2024
@aws-amplify-ap-northeast-2 AWS Amplify (ap-northeast-2)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2208.d3g9cs6u59b8lw.amplifyapp.com

agatha197
agatha197 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 changed the title fix: credential in sidebar is shown keypair-list fix: when user menu is clicked, credential tab is shown instead of user. Feb 14, 2024
@agatha197 agatha197 merged commit f67f1f7 into main Feb 14, 2024
7 checks passed
@agatha197 agatha197 deleted the fix/navigate-credential branch February 14, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

Assignees

@gee05053 gee05053

Labels
size:S 10~30 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gee05053 @agatha197