-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduce SettingList
component for setting page UI
#2212
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
react/src/components/SettingPage.tsx
Outdated
settingOptions: [string, SettingItemProps[]][]; | ||
} | ||
|
||
const SettingPage: React.FC<SettingPageProps> = ({ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
react/src/components/SettingPage.tsx
Outdated
/> | ||
</Flex> | ||
<Flex direction="column" align="start"> | ||
<List |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
SettingList
component for setting page UI
@ironAiken2 please resolve the conflicts :) |
# Conflicts: # react/src/pages/UserSettingsPage.tsx
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 2.93% (-0.04% 🔻) |
102/3486 |
🔴 | Branches | 3.1% (-0.05% 🔻) |
69/2229 |
🔴 | Functions | 1.45% (-0.02% 🔻) |
17/1175 |
🔴 | Lines | 2.98% (-0.04% 🔻) |
102/3422 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / SettingItem.tsx |
0% | 0% | 0% | 0% |
🔴 | ... / SettingList.tsx |
0% | 0% | 0% | 0% |
Test suite run success
20 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 517439a
Thank you for your contribution. I pushed several commits to improve layout and composability. Now, the setting components introduced in this PR are ready to be merged. We need to convert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rolled back UserSettingsPage
and renamed the new version to UserSettingsPage2
. After the setting React hook is ready, let's apply UserSettingsPage2
. Therefore, this PR does not have any impact on the WebUI yet. @agatha197 @ironAiken2
I approve this PR and merge.
🤯 Oh! I forgot to push a commit for rollback. I'll make another PR to fix it and merge. |
This PR Resolves #2209 issue, revamping Setting-related components.
The modifications to the UserSettingPage component serve as an example of how to use the SettingList component. If the PR is approved, will roll back these changes.
Features
UI Changes
Checklist: (if applicable)
How to use
/parents component