Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: current project doesn't apply to vfolder list and session list #2218

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 16, 2024

resolve #2217

This PR makes:

  • Updates the current project based on the Project Select component in WebUIHeader.
  • Persists the selected current project.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:M 30~100 LoC label Feb 16, 2024
Copy link

github-actions bot commented Feb 16, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
3.15% (+0.02% 🔼)
102/3242
🔴 Branches 3.3% 67/2031
🔴 Functions
1.54% (-0% 🔻)
17/1102
🔴 Lines
3.21% (+0.02% 🔼)
102/3182

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 20ee58c

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2218.d3g9cs6u59b8lw.amplifyapp.com

Copy link
Contributor

@gee05053 gee05053 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yomybaby
I tested this PR and checked Vfolder list is changed by current project but I got interval errors.
I added test_project project in groups table and I got a Interval error when I changed current project in header.

스크린샷 2024-02-16 오후 11 21 34

But I don't know that is my mistake or this PR's issue.
Can I get test server or way to add project to test this PR?

@gee05053 gee05053 self-requested a review February 19, 2024 02:10
Copy link
Contributor

@gee05053 gee05053 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yomybaby yomybaby merged commit ac7e1cc into main Feb 19, 2024
8 checks passed
@yomybaby yomybaby deleted the fix/vfolder-list-of-current-project branch February 19, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: project type of vfolder is not included in the vfolder-list
2 participants