Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @typescript-eslint/typescript-estree dependency warning #2225

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 22, 2024

When you run npm run build in /react, you may encounter the following warning:

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0

YOUR TYPESCRIPT VERSION: 5.2.2

Please only submit bug reports when using the officially supported version.

=============

This PR overrides the version of it.

When you reviews, don't forget to run npm install in /react

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3.02% 102/3378
🔴 Branches 3.19% 69/2165
🔴 Functions 1.5% 17/1133
🔴 Lines 3.08% 102/3315

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from eb9d7ca

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 merged commit b570efb into main Feb 22, 2024
8 of 9 checks passed
@agatha197 agatha197 deleted the fix/override-typescript-estree branch February 22, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants