-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build plugin pages and update electron ver. #2226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agatha197
added
type:fix
Fix features that are not working
effort:normal
Need to understand a few modules / some extent of contextual or historical information.
platform:app
App-specific issue
mnt:build-chain
Maintenance: build-chain related issues
urgency:3
Must be finished within a certain time frame.
impact:invisible
This change is invisible to users (internal changes).
labels
Feb 22, 2024
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 2.96% (+0.05% 🔼) |
102/3448 |
🔴 | Branches | 3.14% (+0.05% 🔼) |
69/2195 |
🔴 | Functions | 1.47% (+0.02% 🔼) |
17/1160 |
🔴 | Lines | 3.01% (+0.05% 🔼) |
102/3385 |
Test suite run success
20 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from b6821d5
In sample plugin, |
yomybaby
requested changes
Mar 4, 2024
yomybaby
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort:normal
Need to understand a few modules / some extent of contextual or historical information.
impact:invisible
This change is invisible to users (internal changes).
mnt:build-chain
Maintenance: build-chain related issues
platform:app
App-specific issue
size:XL
500~ LoC
type:fix
Fix features that are not working
urgency:3
Must be finished within a certain time frame.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin pages are not accessible from the electron app. This PR builds both the components and plugins folder.
How to test
config.toml
filee.g) page = "link-test-plugin,admin-plugin"
Checklist for reviewer
Just in case, this is my plugin test page.
set
page = "link-test-plugin"
of theconfig.toml
fileChecklist: (if applicable)