Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Electron live debug mode using LIVE_DEBUG and LIVE_DEBUG_ENDPOINT #2233

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: Electron live debug mode using LIVE_DEBUG and LIVE_DEBUG_ENDPOINT #2233

merged 1 commit into from
Feb 28, 2024

Conversation

yomybaby
Copy link
Member

This PR introduces

  • LIVE_DEBUG: Set to 1 if you want to live debug mode for Electron. The default value is undefined
  • LIVE_DEBUG_ENDPOINT: This variable allows developers to dynamically specify the endpoint URL that the application should connect to during live debugging. The default value is http://127.0.0.1:9081

Example

LIVE_DEBUG=1 npm run electron:d

LIVE_DEBUG=1 LIVE_DEBUG_ENDPOINT=http://warboy-15-local.backend.ai:9081 npm run electron:d

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@yomybaby yomybaby self-assigned this Feb 28, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Feb 28, 2024
agatha197
agatha197 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 merged commit 25f413d into main Feb 28, 2024
6 of 7 checks passed
@agatha197 agatha197 deleted the fix/live-debug-mode-for-electron branch February 28, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

Assignees

@yomybaby yomybaby

Labels
size:S 10~30 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yomybaby @agatha197