Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update outdated Makefile command for building macOS apps #2237

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Mar 4, 2024

This PR is a follow-up to #2013.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@rapsealk rapsealk added the area:docs Documentation. label Mar 4, 2024
@rapsealk rapsealk added this to the 23.09 milestone Mar 4, 2024
@rapsealk rapsealk requested a review from yomybaby March 4, 2024 05:59
@rapsealk rapsealk self-assigned this Mar 4, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Mar 4, 2024
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦅 👁️

@yomybaby yomybaby merged commit e34f3e0 into main Mar 4, 2024
7 of 8 checks passed
@yomybaby yomybaby deleted the docs/update-outdated-makefile-macos-command branch March 4, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentation. size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants