Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: owner info error handling in session launcher #2243

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: owner info error handling in session launcher #2243

merged 2 commits into from
Mar 5, 2024

Conversation

ironAiken2
Copy link
Contributor

This PR Resolves #2240 issue.

Feature

  • Add error handling for empty fields when receiving userInfo data.
  • show notification about error.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@ironAiken2 ironAiken2 requested a review from yomybaby March 5, 2024 07:02
@ironAiken2 ironAiken2 marked this pull request as ready for review March 5, 2024 07:02
@github-actions github-actions bot added the size:S 10~30 LoC label Mar 5, 2024
@yomybaby yomybaby changed the title feat: apply lack of owner info error handling fix: owner info error handling in session launcher Mar 5, 2024
@yomybaby yomybaby merged commit 80ea64e into main Mar 5, 2024
5 of 6 checks passed
@yomybaby yomybaby deleted the feat/session-error-handling branch March 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@ironAiken2 ironAiken2

Labels
size:S 10~30 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's add error handling logic into session luncher when allocating owner
2 participants
@ironAiken2 @yomybaby