hotfix: regression of image info display in serving page #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizable
added
area:ux
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.9% (-0% 🔻) |
102/3512 |
| 🔴 | Branches | 3.09% (-0.01% 🔻) |
69/2235 |
| 🔴 | Functions | 1.44% | 17/1179 |
| 🔴 | Lines | 2.96% (-0% 🔻) |
102/3448 |
Test suite run success
20 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 9b35fe4
yomybaby
requested changes
Mar 6, 2024
| @@ -113,7 +113,26 @@ const RoutingListPage: React.FC<RoutingListPageProps> = () => { | |||
| name | |||
| status | |||
| endpoint_id | |||
| image | |||
There was a problem hiding this comment.
To ensure backward compatibility, we should use different images based on the version.
There was a problem hiding this comment.
I just added conditional statement to check whether current core version supports image_object key in endpoint.
There was a problem hiding this comment.
Please add @deprecatedSince like this:
image @deprecatedSince(version: "23.09.9")
yomybaby
requested changes
Mar 6, 2024
| @@ -113,7 +113,26 @@ const RoutingListPage: React.FC<RoutingListPageProps> = () => { | |||
| name | |||
| status | |||
| endpoint_id | |||
| image | |||
There was a problem hiding this comment.
Please add @deprecatedSince like this:
image @deprecatedSince(version: "23.09.9")
yomybaby
requested changes
Mar 6, 2024
react/src/pages/ServingListPage.tsx
Outdated
Comment on lines
275
to
276
| image | ||
| image_object @since(version: "23.09.9") { |
There was a problem hiding this comment.
Thia page doesn't use image and image_object, right?. If yes, please remove these in this file.
yomybaby
deleted the
hotfix/regression-of-image-info-display-in-serving-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: (if applicable)
This PR fixes two thing,
Show full-image string in Routing page, as a regression of replacing deprecated
imagekey inendpointtoimage_object.Supports architecture on same image string (multiarch) by extracting from full-image string
Core(manager) version:
23.9.9~How to test:
Start servicebutton.cr.backend.ai/multiarch/python:3.9-ubuntu20.04@aarch64) in manual image input fieldCreatebutton.