Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change to select colors via token #2247

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Mar 7, 2024

This PR Resolves #2246 issue.

Feature

  • set mwc button bg and progress bar color via token. For dark mode, I used colorPrimary.
  • The colors will be changed depending on the theme.
  • Changed the hard-coded color using antd token.

Reflected request changes

  • set BAI app download button to non-primary and non-shadow, and fixed width between button and selector. I added icons to help users understand.
  • rollback manager info tag color in information page.
  • delete colorDisabled in theme.json.
image

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@ironAiken2 ironAiken2 requested a review from yomybaby March 7, 2024 05:13
@github-actions github-actions bot added the size:M 30~100 LoC label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 2.9% 102/3512
🔴 Branches 3.09% 69/2235
🔴 Functions 1.44% 17/1179
🔴 Lines 2.96% 102/3448

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 5a35e1c

@ironAiken2 ironAiken2 marked this pull request as draft March 7, 2024 06:35
@ironAiken2 ironAiken2 marked this pull request as ready for review March 8, 2024 02:13
@yomybaby
Copy link
Member

yomybaby commented Mar 8, 2024

image image

Let's change this download button to non-primary and non-shadow. It's not the primary action, and it's not on the same level as the "start" button.

  • please match the grid.

@yomybaby
Copy link
Member

yomybaby commented Mar 8, 2024

image image

The color of the progress bar in dark mode is brighter than in light mode. Could you fix this?

@yomybaby
Copy link
Member

yomybaby commented Mar 8, 2024

image

Please change the color of the icon in "지역" column.

@yomybaby
Copy link
Member

yomybaby commented Mar 8, 2024

Before
image

After this PR
image

The "before" is better.

resources/theme.json Outdated Show resolved Hide resolved
@ironAiken2
Copy link
Contributor Author

ironAiken2 commented Mar 8, 2024

@yomybaby
I reflect changes requested.
However, the icons representing regions on the agent page are saved as pngs, which prevents me from changing their color.

In a previous commit, I had a misunderstanding about the theme.json file. now it's fixed

@@ -129,11 +126,14 @@ export const BackendAiStyles = [
--general-progress-bar-bg: var(--token-colorBorderSecondary, #e8e8e8);
--general-progress-bar-reserved: linear-gradient(
to left,
#722cd7,
#5c7cfa
var(--token-blue-8) 0%,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yomybaby
This is the part that controls the gradient color of the progress bar.

Copy link
Member

@yomybaby yomybaby Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to remove the gradient color of the progress bar.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yomybaby yomybaby merged commit 8888051 into main Mar 8, 2024
7 of 8 checks passed
@yomybaby yomybaby deleted the fix/unify-color-consistency branch March 8, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's unify color consistency with token colors
2 participants