Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fixed to be able to dynamically change colors. #2254

Merged
merged 2 commits into from
Mar 11, 2024
Merged

feat: fixed to be able to dynamically change colors. #2254

merged 2 commits into from
Mar 11, 2024

Conversation

ironAiken2
Copy link
Contributor

This PR Resolves #2253 issue.

The nested background color of the total allocation panel in the session launcher now changes depending on the dark mode theme.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@ironAiken2 ironAiken2 self-assigned this Mar 11, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Mar 11, 2024
agatha197

This comment was marked as resolved.

Sign in to view

@agatha197 agatha197 self-requested a review March 11, 2024 07:40
agatha197
agatha197 requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

light -> dark -> light
image

agatha197
agatha197 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 merged commit 249edae into main Mar 11, 2024
5 of 6 checks passed
@agatha197 agatha197 deleted the feat/dynamic-color-in-sessionLauncher branch March 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

Assignees

@ironAiken2 ironAiken2

Labels
size:S 10~30 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's modify the total allocation panel to change its background color according to the darkmode theme.
2 participants
@ironAiken2 @agatha197