Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regression of built-in app in session execution when app itself is refreshed in Windows Desktop app #2256

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: regression of built-in app in session execution when app itself is refreshed in Windows Desktop app #2256

merged 1 commit into from
Mar 12, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Mar 11, 2024 •
edited

This PR fixes bug when built-in app in session execution fails when refreshes app itself inside Desktop application especially in Windows environment.

  • Manager version: 23.09.10rc2~

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@lizable lizable self-assigned this Mar 11, 2024
@lizable lizable requested review from inureyes and adrysn March 11, 2024 10:41
@github-actions github-actions bot added the size:XS ~10 LoC label Mar 11, 2024
@lizable lizable added urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING and removed size:XS ~10 LoC labels Mar 11, 2024
@lizable lizable added this to the 23.09 milestone Mar 11, 2024
@lizable lizable marked this pull request as ready for review March 11, 2024 10:41
@lizable lizable changed the title fix: set global variable __local_proxy in window object for app execution fix: regression of built-in app in session execution when app itself is refreshed in Windows Desktop app Mar 12, 2024
@adrysn adrysn merged commit 3bdc4fa into main Mar 12, 2024
8 of 9 checks passed
@adrysn adrysn deleted the hotfix/enable-app-execution-on-windows-app branch March 12, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inureyes inureyes Awaiting requested review from inureyes

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@lizable lizable

Labels
urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lizable @adrysn