Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: modify background color more naturally #2257

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

ironAiken2
Copy link
Contributor

This PR Resolves #2255 issue.

Feature

  • remove background color in mwc-button

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@ironAiken2 ironAiken2 self-assigned this Mar 12, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Mar 12, 2024
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a side effect like below.
image
image

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Can you handle this too? @ironAiken2 In the dark mode, it's hard to read.

@agatha197 agatha197 changed the title fix: remove background color in mwc-icon style: modify background color more naturally Mar 12, 2024
@agatha197 agatha197 merged commit 193f3f8 into main Mar 12, 2024
5 of 6 checks passed
@agatha197 agatha197 deleted the feat/icon-background-change branch March 12, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the icon background color in vFolder modals
2 participants