Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Quota Scope ID in data page's storage status panel #2259

Merged
merged 7 commits into from
Mar 26, 2024
Merged

feat: Quota Scope ID in data page's storage status panel #2259

merged 7 commits into from
Mar 26, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Mar 12, 2024 •
edited

This PR Resolves #2251 issue.

Feature

  • show quota scope id (user id) in storage status panel.
  • change antd's descriptions column because 2 line representation is visually better than 3 line representation.
    (I've tried showing text at the bottom of the card without using descriptions.item, but it doesn't feel consistent.)
  • modify the way render descriptions items that is appropriate for the current antd version. The old way was used in versions 5.8.0 and earlier.
image

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@ironAiken2 ironAiken2 self-assigned this Mar 12, 2024
@github-actions github-actions bot added effort:easy Need to understand only a specific region of codes (good first issue, easy). field:UI / UX size:S 10~30 LoC type:enhance Add new features urgency:3 Must be finished within a certain time frame. size:XS ~10 LoC and removed field:UI / UX labels Mar 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 12, 2024 •
edited

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
2.9% (-0% 🔻)
 102/3516
🔴 Branches
3.08% (-0% 🔻)
 69/2241
🔴 Functions 1.44% 17/1179
🔴 Lines
2.95% (-0% 🔻)
 102/3452

Test suite run success

20 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 5b03f61

yomybaby
yomybaby requested changes Mar 13, 2024
View reviewed changes
react/src/components/StorageStatusPanel.tsx Outdated
<Card size="small" title={t('data.StorageStatus')}>
<Descriptions bordered column={columnSetting} size="small">
<Descriptions.Item label={t('data.NumberOfFolders')}>
const descriptionItem: DescriptionsProps['items'] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename descriptionItem to descriptionItems because it's array.

react/src/components/StorageStatusPanel.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the size:S 10~30 LoC label Mar 13, 2024
@lizable lizable added this to the 23.09 milestone Mar 25, 2024
lizable
lizable approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yomybaby yomybaby changed the title feat: show UUID in data page's storage status panel feat: Quota Scope ID in data page's storage status panel Mar 25, 2024
@github-actions github-actions bot removed the size:S 10~30 LoC label Mar 26, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Mar 26, 2024
yomybaby
yomybaby approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit 53983b0 into main Mar 26, 2024
8 checks passed
@yomybaby yomybaby deleted the feat/visualize-quota-scope-id branch March 26, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

@lizable lizable lizable approved these changes

Assignees

@ironAiken2 ironAiken2

Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). field:localization field:UI / UX size:L 100~500 LoC size:S 10~30 LoC type:enhance Add new features urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Let's add quota scope id of Vfolder in storage list
3 participants
@ironAiken2 @yomybaby @lizable