Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression of imageInfo initialization for categorizing environments by label in metadata #2267

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Mar 22, 2024

This PR fixes regression issue of missing categories in "environment select UI" inside session-launcher.
All of image except custom image, which is without description in metadata, should be grouped with the title defined in
metadata.json.
For more details, please look through the code below.

this.supportImages[supportsKey] = this.imageInfo[imageName] || {
name: 'Custom Environments',
description: 'Custom-built images.',
group: 'Custom Environments',
tags: [],
label: [
{
category: 'Custom',
tag: 'Custom',
color: 'black',
},
],
};

After before
Screenshot 2024-03-22 at 3 33 51 PM Screenshot 2024-03-22 at 3 34 08 PM

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • [] Test case(s) to demonstrate the difference of before/after

@lizable lizable added urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING size:XS ~10 LoC labels Mar 22, 2024
@lizable lizable added this to the 23.09 milestone Mar 22, 2024
@lizable lizable self-assigned this Mar 22, 2024
@lizable lizable marked this pull request as ready for review March 22, 2024 06:40
@inureyes
Copy link
Member

LGTM

Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. urgency:5 It is imperative that action be taken right away. platform:general impact:visible This change is visible to users. field:UI / UX labels Mar 22, 2024
@inureyes inureyes merged commit 90710e5 into main Mar 22, 2024
15 checks passed
@inureyes inureyes deleted the hotfix/show-category-in-session-environment-select branch March 22, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). field:UI / UX impact:visible This change is visible to users. platform:general size:XS ~10 LoC type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING urgency:5 It is imperative that action be taken right away.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants