fix: use ref of the Form instead of the useForm function in the Modal
#2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.9% | 102/3518 |
| 🔴 | Branches | 3.07% | 69/2245 |
| 🔴 | Functions | 1.44% | 17/1179 |
| 🔴 | Lines | 2.95% | 102/3454 |
Test suite run success
20 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from bc90984
yomybaby
added a commit
that referenced
this pull request
Apr 1, 2024
yomybaby
added a commit
that referenced
this pull request
Apr 1, 2024
* style: update hard coded color of sftp dialog * style: change color for better UI * feat: change mwc button color and fill missed i18n * style: change slider text color * docs: fill missed translations * Update zh-TW translation for "InactivateTheFollowingUsers" * add missing i18n * revert missing `id.json` strings by #2270 --------- Co-authored-by: Jong Eun Lee <jongeun@lablup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #2178. Please read the description of #2178.
This PR makes the modal component, which contains a Form, use the
refprop to get the instance of theForminstead of setting theformprop usingForm.useForm.Checklist: (if applicable)