style: fix the broken select UI of the new storage folder dialog #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agatha197
added
type:fix
yomybaby
reviewed
Mar 29, 2024
Comment on lines
1
to
25
| diff --git a/node_modules/@material/mwc-select/mwc-select-base.js b/node_modules/@material/mwc-select/mwc-select-base.js | ||
| index 66a2c20..6914121 100644 | ||
| index 66a2c20..efcbb8e 100644 | ||
| --- a/node_modules/@material/mwc-select/mwc-select-base.js | ||
| +++ b/node_modules/@material/mwc-select/mwc-select-base.js | ||
| @@ -128,6 +128,14 @@ export class SelectBase extends FormElement { | ||
| @@ -128,6 +128,16 @@ export class SelectBase extends FormElement { | ||
| const labelledby = !!this.label ? 'label' : undefined; | ||
| const describedby = this.shouldRenderHelperText ? 'helper-text' : undefined; | ||
| return html ` | ||
| + <style> | ||
| + .mdc-select__anchor { | ||
| + min-width: var(--mdc-select-min-width, 200px); | ||
| + max-width: var(--mwc-select-max-width, 100%); | ||
| + } | ||
| + .mdc-select--filled { | ||
| + min-width: var(--mdc-select-min-width, 200px); | ||
| + max-width: var(--mwc-select-max-width, 100%); | ||
| + } | ||
| + </style> | ||
| <div | ||
| class="mdc-select ${classMap(classes)}"> | ||
| <input | ||
| @@ -247,7 +255,7 @@ export class SelectBase extends FormElement { | ||
| @@ -247,7 +257,7 @@ export class SelectBase extends FormElement { | ||
| if (!this.icon) { | ||
| return nothing; | ||
| } |
There was a problem hiding this comment.
Without this patch file, it works properly with backend-ai-data-view.ts changes. Is this paths is required? @agatha197
There was a problem hiding this comment.
You are right. I reverted it.
github-actions
bot
added
size:XS
agatha197
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows #2268
Before
After
Checklist: (if applicable)