Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display Quota per storage volume info if quota is available #2285

Merged
merged 5 commits into from
Apr 1, 2024
Merged

feat: display Quota per storage volume info if quota is available #2285

merged 5 commits into from
Apr 1, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Apr 1, 2024 •
edited

fix: remove quotaSupportStorageBackends from backend-ai-data-view because it is not used.
resolves https://github.com/lablup/giftbox/issues/642
follows #2180

Descriptions

Problem: A problem that does not show Quota per storage volume even though a storage supports quota.
Cause: The value of selectedVolumeInfo changed to a string (single string of hostname) instead of an object.
Resolution: Set the value of selectedVolumeInfo as the second factor of onChange in StorageSelect

How to test

Checklist

  • If selected storage supports quota, can you see the Quota per storage volume ?
  • Highlighting/Searching storage host is available?

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197
feat: add netapp to quotaSupportStorageBackends
35104a2 
fix: remove `quotaSupportStorageBackends` from backend-ai-data-view because it is not used.
@agatha197 agatha197 added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). urgency:5 It is imperative that action be taken right away. platform:general impact:invisible This change is invisible to users (internal changes). labels Apr 1, 2024
@agatha197 agatha197 added this to the 24.03 milestone Apr 1, 2024
@agatha197 agatha197 self-assigned this Apr 1, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Apr 1, 2024
@agatha197 agatha197 marked this pull request as draft April 1, 2024 06:41
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Apr 1, 2024
@agatha197 agatha197 marked this pull request as ready for review April 1, 2024 09:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
3.13% (-0% 🔻)
 117/3739
🔴 Branches 3.56% 87/2447
🔴 Functions
1.53% (-0% 🔻)
 19/1241
🔴 Lines
3.08% (-0% 🔻)
 113/3666

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 24c099f

@agatha197 agatha197 changed the title feat: add netapp as the quota-enabled storage in Web UI feat: display Quota per storage volume info if quota is available Apr 1, 2024
yomybaby
yomybaby approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I push a commit to fix TypeScript type definition for onChange.
After that, LGTM!

@agatha197 agatha197 merged commit 0666109 into main Apr 1, 2024
8 checks passed
@agatha197 agatha197 deleted the feature/make-netapp-storage-available-quota branch April 1, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@agatha197 agatha197

Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:invisible This change is invisible to users (internal changes). platform:general size:S 10~30 LoC type:fix Fix features that are not working urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @yomybaby