Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If the language setting is not 'en' or 'kr', change the language value to 'en'. #2291

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

ironAiken2
Copy link
Contributor

This PR Resolves #2290 Issue.

Feature:

  • If the language setting is not 'en' or 'kr', change the language value to 'en'.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@ironAiken2 ironAiken2 requested a review from lizable April 2, 2024 08:03
@ironAiken2 ironAiken2 self-assigned this Apr 2, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3.13% 117/3739
🔴 Branches
3.55% (-0% 🔻)
87/2449
🔴 Functions 1.53% 19/1241
🔴 Lines 3.08% 113/3666

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 476848f

Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lizable lizable merged commit 6647037 into main Apr 2, 2024
9 checks passed
@lizable lizable deleted the fix/webui-help-button-navigate branch April 2, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webui help button navigation not working well when the language setting is not 'en' or 'kr'
2 participants