Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display accelerator key instead of empty string #2294

Merged
merged 2 commits into from
Apr 5, 2024
Merged

feat: display accelerator key instead of empty string #2294

merged 2 commits into from
Apr 5, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Apr 3, 2024 •
edited

follows #1651

  • Add IPU translations.

Before
image

After
image
If the translation string is not included, it shows the key. (For example, IPU)
image

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. type:refactor Refactoring current implementation. platform:general impact:visible This change is visible to users. field:UI / UX labels Apr 3, 2024
@agatha197 agatha197 added this to the 23.09 milestone Apr 3, 2024
@agatha197 agatha197 self-assigned this Apr 3, 2024
@agatha197 agatha197 requested a review from lizable April 5, 2024 05:57
lizable
lizable approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lizable lizable merged commit fc2fdb9 into main Apr 5, 2024
5 checks passed
@lizable lizable deleted the feature/generalize-idle-checker branch April 5, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizable lizable lizable approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

@kmkwon94 kmkwon94 Awaiting requested review from kmkwon94

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). field:localization field:UI / UX impact:visible This change is visible to users. platform:general size:M 30~100 LoC type:refactor Refactoring current implementation. urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @lizable