Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable download button when download perm is not allowed #2295

Merged
merged 4 commits into from
Apr 4, 2024
Merged

fix: disable download button when download perm is not allowed #2295

merged 4 commits into from
Apr 4, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Apr 4, 2024 •
edited

This PR disallows downloading files by clicking download button in folder explorer when the permissions of corresponding storage host doesn't include download-file.

⚠️ NOTE: You should refresh the page when permissions are updated.

Please check,

  • Download file/folder in folder-explorer only if download-file permission is allowed.
  • Not allowed to download file/folder when there's no download-file permission in corresponding storage host.

Screenshot(s) of when download-file permission is not allowed

After Before
Screenshot 2024-04-04 at 12 54 37 PM Screenshot 2024-04-04 at 11 23 11 AM

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@lizable lizable added type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING type:refactor Refactoring current implementation. size:XS ~10 LoC labels Apr 4, 2024
@lizable lizable self-assigned this Apr 4, 2024
agatha197
agatha197 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 merged commit 2b9b097 into main Apr 4, 2024
5 checks passed
@agatha197 agatha197 deleted the fix/disable-download-btn-when-download-perm-is-not-allowed branch April 4, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@ironAiken2 ironAiken2 Awaiting requested review from ironAiken2

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@lizable lizable

Labels
field:localization field:UI / UX size:L 100~500 LoC type:fix Fix features that are not working type:refactor Refactoring current implementation. urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lizable @agatha197