Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: update description of type of login account in login panel #2301

Merged
merged 2 commits into from
Apr 5, 2024
Merged

misc: update description of type of login account in login panel #2301

merged 2 commits into from
Apr 5, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Apr 5, 2024 •
edited

Sometimes users login their own ID account instead of email address, which may confuse them in login panel, which only shows "Login with E-mail" or "Login with IAM". This PR will fix this situation by adding "Username" to description in there.

After Before
Screenshot 2024-04-05 at 10 41 39 AM Screenshot 2024-04-05 at 10 21 09 AM

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@lizable lizable requested review from adrysn and yomybaby April 5, 2024 01:33
@lizable lizable self-assigned this Apr 5, 2024
@lizable lizable added effort:easy Need to understand only a specific region of codes (good first issue, easy). urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. type:refactor Refactoring current implementation. impact:visible This change is visible to users. and removed size:XL 500~ LoC field:localization labels Apr 5, 2024
@lizable lizable added this to the 23.09 milestone Apr 5, 2024
yomybaby
yomybaby approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit b819947 into main Apr 5, 2024
5 checks passed
@yomybaby yomybaby deleted the misc/apply-desc-on-login-panel branch April 5, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

@adrysn adrysn Awaiting requested review from adrysn

Assignees

@lizable lizable

Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). field:localization field:UI / UX impact:visible This change is visible to users. size:XL 500~ LoC type:refactor Refactoring current implementation. urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lizable @yomybaby