Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vfolder-trash-bin is duplicated #2305

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: vfolder-trash-bin is duplicated #2305

merged 1 commit into from
Apr 5, 2024

Conversation

agatha197
Copy link
Contributor

follows #2303
duplicated code with line number 689.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). urgency:3 Must be finished within a certain time frame. platform:general impact:invisible This change is invisible to users (internal changes). labels Apr 5, 2024
@agatha197 agatha197 added this to the 24.03 milestone Apr 5, 2024
@agatha197 agatha197 requested a review from yomybaby April 5, 2024 06:06
@agatha197 agatha197 self-assigned this Apr 5, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Apr 5, 2024
yomybaby
yomybaby approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit 38f2b1b into main Apr 5, 2024
11 checks passed
@yomybaby yomybaby deleted the bugfix/duplicated-definition-of-vfolder-trash-bin branch April 5, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

Assignees

@agatha197 agatha197

Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:invisible This change is invisible to users (internal changes). platform:general size:XS ~10 LoC type:fix Fix features that are not working urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @yomybaby