Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: session list fetch error #2307

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: session list fetch error #2307

merged 1 commit into from
Apr 5, 2024

Conversation

agatha197
Copy link
Contributor

fix: fetch image_object when supporting per-user-image to fix the error that occurs fetching the session list in 23.09

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING urgency:5 It is imperative that action be taken right away. labels Apr 5, 2024
@agatha197 agatha197 added this to the 23.09 milestone Apr 5, 2024
@agatha197 agatha197 requested a review from yomybaby April 5, 2024 09:03
@agatha197 agatha197 self-assigned this Apr 5, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Apr 5, 2024
yomybaby
yomybaby approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit 0fa3b9d into main Apr 5, 2024
8 checks passed
@yomybaby yomybaby deleted the hotfix/session-list-fetch-error branch April 5, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

Assignees

@agatha197 agatha197

Labels
size:S 10~30 LoC urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @yomybaby