Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply AI accelerator allocation when selecting resource preset in neo session launcher #2308

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Apr 5, 2024

This PR resolves AI accelerator doesn't move when user selects resoruce preset from the list in neo session launcher and :

Screen.Recording.2024-04-05.at.6.31.17.PM.mov
Screenshot 2024-04-05 at 6 32 05 PM

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@lizable lizable requested a review from yomybaby April 5, 2024 09:32
@lizable lizable added this to the 24.03 milestone Apr 5, 2024
@lizable lizable self-assigned this Apr 5, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Apr 5, 2024
@lizable lizable added type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING size:XS ~10 LoC and removed size:S 10~30 LoC labels Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
3.1% (-0.01% 🔻)
117/3776
🔴 Branches
3.49% (-0.01% 🔻)
87/2495
🔴 Functions
1.52% (-0% 🔻)
19/1246
🔴 Lines
3.05% (-0.01% 🔻)
113/3702

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 848271b

@github-actions github-actions bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Apr 5, 2024
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit 7f4c1be into main Apr 5, 2024
8 checks passed
@yomybaby yomybaby deleted the hotfix/apply-accelerator-allocation-by-resource-preset-selection branch April 5, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants