Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tooltip for submit button #2311

Merged

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Apr 6, 2024

After this PR, users will be able to see the tooltip when hovering the mouse pointer over the disabled submit button.

image

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

github-actions bot commented Apr 6, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3.09% 117/3792
🔴 Branches
3.46% (-0% 🔻)
87/2517
🔴 Functions 1.52% 19/1254
🔴 Lines 3.04% 113/3718

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 5cfbacf

@yomybaby yomybaby merged commit 3a20fa4 into main Apr 6, 2024
9 checks passed
@yomybaby yomybaby deleted the feat/validation-tooltip-on-neo-session-launcher-submit branch April 6, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant