Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: touchup container commit feature #2314

Merged
merged 4 commits into from
Apr 6, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Apr 6, 2024

  • Core version: 24.03.0 or later

This PR mainly fixes cosmetic issues in container commit dialog:

  • Change button label from Commit to Push session to customized image when checkbox in "Convert session to image" session is checked
  • Add placeholder(4~32 chars) and proper validation msg in the input-field of "Convert session to image" section
  • (FIXME) Temporally disable container commit icon when session is not created by user*
    (For now, even if superadmin role tries to do container commit or push session to image, the server throws "No such session" response.)

Screenshot(s)

After Before
Screenshot 2024-04-06 at 4 54 06 PM Screenshot 2024-04-06 at 5 15 23 PM

|

  • After
    Screenshot 2024-04-06 at 5 19 19 PM
  • Before
    Screenshot 2024-04-06 at 5 14 46 PM

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@lizable lizable added this to the 24.03 milestone Apr 6, 2024
@lizable lizable self-assigned this Apr 6, 2024
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit bc84173 into main Apr 6, 2024
6 checks passed
@yomybaby yomybaby deleted the hotfix/touchup-container-commit-feature branch April 6, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants