Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add css variable to vaadin grid for plugin page #2325

Merged
merged 1 commit into from
Apr 9, 2024
Merged

style: add css variable to vaadin grid for plugin page #2325

merged 1 commit into from
Apr 9, 2024

Conversation

agatha197
Copy link
Contributor

For plugin pages that use backend-ai-storage-proxy-list.ts, the grid size is too large. So I added CSS variable to vaadin-grid. The --list-height is already used in many plugin pages.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:enhance Add new features effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores. platform:general impact:visible This change is visible to users. field:UI / UX labels Apr 9, 2024
@agatha197 agatha197 added this to the 24.03 milestone Apr 9, 2024
@agatha197 agatha197 requested a review from yomybaby April 9, 2024 04:38
@agatha197 agatha197 self-assigned this Apr 9, 2024
@github-actions github-actions bot added size:XS ~10 LoC and removed field:UI / UX labels Apr 9, 2024
inureyes
inureyes approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit 6554e56 into main Apr 9, 2024
13 checks passed
@inureyes inureyes deleted the style/add-css-variable-for-plugin-page branch April 9, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inureyes inureyes inureyes approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

Assignees

@agatha197 agatha197

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:visible This change is visible to users. platform:general size:XS ~10 LoC type:enhance Add new features urgency:2 With time limit, it should be finished within it; otherwise, resolve it when no other chores.
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @inureyes