Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump actions/labeler from 4 to 5 #2342

Merged
merged 3 commits into from
Apr 30, 2024
Merged

ci: Bump actions/labeler from 4 to 5 #2342

merged 3 commits into from
Apr 30, 2024

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Apr 16, 2024

As the labeler became version v5, its usage has changed.

any: match ALL globs against ANY changed path
all: match ALL globs against ALL changed paths

From the existing two rules that could be used,

any-glob-to-any-file: ANY glob must match against ANY changed file
any-glob-to-all-files: ANY glob must match against ALL changed files
all-globs-to-any-file: ALL globs must match against ANY changed file
all-globs-to-all-files: ALL globs must match against ALL changed files

It has been added so that it can be used in 4 ways.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added the size:S 10~30 LoC label Apr 16, 2024
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Apr 16, 2024
@Yaminyam Yaminyam marked this pull request as ready for review April 16, 2024 07:18
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit 44f8713 into main Apr 30, 2024
5 checks passed
@inureyes inureyes deleted the ci/update-labeler branch April 30, 2024 01:10
@inureyes inureyes added this to the 24.03 milestone Apr 30, 2024
@inureyes inureyes added effort:easy Need to understand only a specific region of codes (good first issue, easy). mnt:build-chain Maintenance: build-chain related issues area:upstream Upstream issue. impact:invisible This change is invisible to users (internal changes). status:done Worked on it and completed. github_actions Pull requests that update GitHub Actions code labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:upstream Upstream issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). github_actions Pull requests that update GitHub Actions code impact:invisible This change is invisible to users (internal changes). mnt:build-chain Maintenance: build-chain related issues size:M 30~100 LoC status:done Worked on it and completed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants