Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use defaultSessionEnvironment as a initial environments.environment #2345

Merged
merged 3 commits into from
Apr 16, 2024
Merged

fix: use defaultSessionEnvironment as a initial environments.environment #2345

merged 3 commits into from
Apr 16, 2024

Conversation

yomybaby
Copy link
Member

This PR follows up on #2337 and resolves #2336.

After this PR, the defaultSessionEnvironment will be used as the initial environments.environment form value for Neo Session Launcher.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions bot added effort:normal Need to understand a few modules / some extent of contextual or historical information. impact:visible This change is visible to users. type:fix Fix features that are not working urgency:4 As soon as feasible, implementation is essential. size:S 10~30 LoC labels Apr 16, 2024
@yomybaby yomybaby requested a review from lizable April 16, 2024 11:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
3% (-0.01% 🔻)
 118/3933
🔴 Branches
3.28% (-0.01% 🔻)
 87/2652
🔴 Functions
1.46% (-0% 🔻)
 19/1301
🔴 Lines
2.96% (-0.01% 🔻)
 114/3855

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 43048c4

lizable
lizable approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on both web browser and app.
LGTM.

@lizable lizable merged commit 2576f58 into main Apr 16, 2024
8 checks passed
@lizable lizable deleted the fix/default-session-environment-as-initial-environment-value branch April 16, 2024 12:22
@yomybaby yomybaby mentioned this pull request Apr 17, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizable lizable lizable approved these changes

Assignees

@yomybaby yomybaby

Labels
effort:normal Need to understand a few modules / some extent of contextual or historical information. impact:visible This change is visible to users. size:S 10~30 LoC type:fix Fix features that are not working urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot apply default session environment in Neo session launcher
2 participants
@yomybaby @lizable