Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: enable non-accelerator preset when accelerator image #2346

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Apr 16, 2024

  • If there is no accelerator requirement in the image:

    • Exclude accelerators presets.
    • Disable the accelerator input field.
  • If there is an accelerator requirement in the image:

    • (After this PR) Show non-accelerator presets also.
    • Enable the accelerator input field.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@yomybaby yomybaby requested a review from lizable April 16, 2024 13:31
@github-actions github-actions bot added the size:S 10~30 LoC label Apr 16, 2024
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 3% 118/3933
🔴 Branches
3.28% (-0% 🔻)
87/2656
🔴 Functions 1.46% 19/1301
🔴 Lines 2.96% 114/3855

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 3f909f4

Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now Resource Preset Select in Neo session launcher works as same as "Classic" one.
LGTM.

@lizable lizable merged commit d511e0b into main Apr 16, 2024
9 checks passed
@lizable lizable deleted the hotfix/disable-resource-preset-based-on-image branch April 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants