Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: listup only ready status vfolder on service launcher #2354

Merged
merged 3 commits into from
Apr 18, 2024
Merged

hotfix: listup only ready status vfolder on service launcher #2354

merged 3 commits into from
Apr 18, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Apr 18, 2024 •
edited

  • Core Version: 23.09 or newer.

This PR resolves #2353.
For the test case, please refer to the issue mentioned above.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minimum required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@lizable lizable added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). area:ux UI / UX issue. urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING impact:visible This change is visible to users. size:XS ~10 LoC labels Apr 18, 2024
@lizable lizable self-assigned this Apr 18, 2024
@lizable lizable added this to the 23.09 milestone Apr 18, 2024
@github-actions github-actions bot added size:S 10~30 LoC and removed size:XS ~10 LoC labels Apr 18, 2024
@github-actions GitHub Actions
Copy link

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements 3% 118/3933
🔴 Branches
3.27% (-0% 🔻)
 87/2658
🔴 Functions 1.46% 19/1301
🔴 Lines 2.96% 114/3855

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 6070f45

@lizable lizable marked this pull request as ready for review April 18, 2024 02:59
ironAiken2
ironAiken2 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ironAiken2 ironAiken2 merged commit 84fff94 into main Apr 18, 2024
14 checks passed
@ironAiken2 ironAiken2 deleted the hotfix/listup-only-ready-status-vfolder-on-service-launcher branch April 18, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironAiken2 ironAiken2 ironAiken2 approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

@agatha197 agatha197 Awaiting requested review from agatha197

Assignees

@lizable lizable

Labels
area:ux UI / UX issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:visible This change is visible to users. size:S 10~30 LoC type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

Vfolder list in model service launcher shows deleted vfolder(s)
2 participants
@lizable @ironAiken2