Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parsing valid appConnectUrl #2358

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix: parsing valid appConnectUrl #2358

merged 2 commits into from
Apr 22, 2024

Conversation

agatha197
Copy link
Contributor

Since _connectProxyWorker returns object, the previous result of appConnectUrl is nested object.
This PR is parsing it properly.

follows #2310

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING labels Apr 19, 2024
@agatha197 agatha197 added this to the 24.03 milestone Apr 19, 2024
@agatha197 agatha197 requested a review from yomybaby April 19, 2024 05:56
@agatha197 agatha197 self-assigned this Apr 19, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Apr 19, 2024
yomybaby
yomybaby approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit db24c44 into main Apr 22, 2024
5 checks passed
@yomybaby yomybaby deleted the bugfix/appConnectUrl-is-nested-object branch April 22, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby approved these changes

Assignees

@agatha197 agatha197

Labels
field:localization field:UI / UX size:M 30~100 LoC type:fix Fix features that are not working urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agatha197 @yomybaby