fix: onChangeAliasMap is triggered on every render
#2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 3% | 118/3935 |
| 🔴 | Branches | 3.27% | 87/2662 |
| 🔴 | Functions | 1.46% | 19/1302 |
| 🔴 | Lines | 2.95% | 114/3858 |
Test suite run success
32 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 8276e89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2368.
This is a side effect of #2359
Before this PR,
VFolderTablewas triggeringonChangeSelectedRowKeyson every render if the parent component passedselectedRowKeysas a new instance of an array.VFolderTableshould consider this scenario.Checklist: (if applicable)